Skip to content

fix(authz): [FC-0099] update roles label in TeamTable#10

Merged
brian-smith-tcril merged 1 commit intoopenedx:masterfrom
eduNEXT:dcoa/fix-roles-team-table
Oct 22, 2025
Merged

fix(authz): [FC-0099] update roles label in TeamTable#10
brian-smith-tcril merged 1 commit intoopenedx:masterfrom
eduNEXT:dcoa/fix-roles-team-table

Conversation

@dcoa
Copy link
Copy Markdown
Contributor

@dcoa dcoa commented Oct 13, 2025

Fix roles label in team table

This Pr update the chip component in the Team Table to display the name of the roles based on the metadata defined here #5

Before
image

After

image

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Oct 13, 2025
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Oct 13, 2025 •
edited
Loading

Thanks for the pull request, @dcoa!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Oct 13, 2025
@dcoa dcoa changed the title fix: update roles label in team table fix(authz): [FC-0099] update roles label in team table Oct 13, 2025
@dcoa dcoa changed the title fix(authz): [FC-0099] update roles label in team table fix(authz): [FC-0099] update roles label in TeamTable Oct 13, 2025
@dcoa dcoa marked this pull request as draft October 13, 2025 05:42
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Oct 15, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Oct 15, 2025
@dcoa dcoa force-pushed the dcoa/fix-roles-team-table branch from 56f51b4 to 16515df Compare October 20, 2025 05:27
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.76%. Comparing base (c5cab49) to head (16515df).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   90.71%   90.76%   +0.05%     
==========================================
  Files          19       19              
  Lines         183      184       +1     
  Branches       23       23              
==========================================
+ Hits          166      167       +1     
  Misses         17       17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcoa dcoa marked this pull request as ready for review October 20, 2025 05:29
@dcoa
Copy link
Copy Markdown
Contributor Author

dcoa commented Oct 20, 2025

@arbrandes @jacobo-dominguez-wgu this is a small fix

jacobo-dominguez-wgu
jacobo-dominguez-wgu approved these changes Oct 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@jacobo-dominguez-wgu jacobo-dominguez-wgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it on the sandbox and the roles chip looks good to me 👍

@brian-smith-tcril brian-smith-tcril mentioned this pull request Oct 22, 2025
Closed
brian-smith-tcril
brian-smith-tcril approved these changes Oct 22, 2025
View reviewed changes
Copy link
Copy Markdown

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tested locally and the role names are appearing nicely!

Comment thread src/authz-module/libraries-manager/components/TeamTable.tsx
Header: intl.formatMessage(messages['library.authz.team.table.roles']),
accessor: 'roles',
Cell: RolesCell,
// eslint-disable-next-line react/no-unstable-nested-components
Copy link
Copy Markdown

@brian-smith-tcril brian-smith-tcril Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge fan of ignoring eslint rules, but I see this is already being done earlier in this file

frontend-app-admin-console/src/authz-module/libraries-manager/components/TeamTable.tsx

Line 76 in 52fbb7e

// eslint-disable-next-line react/no-unstable-nested-components

I created an issue to track this

@brian-smith-tcril brian-smith-tcril merged commit 315e5c6 into openedx:master Oct 22, 2025
6 checks passed
@github-project-automation github-project-automation Bot moved this from Waiting on Author to Done in Contributions Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brian-smith-tcril brian-smith-tcril brian-smith-tcril approved these changes

@jacobo-dominguez-wgu jacobo-dominguez-wgu jacobo-dominguez-wgu approved these changes

@arbrandes arbrandes Awaiting requested review from arbrandes

Assignees

No one assigned

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dcoa @openedx-webhooks @brian-smith-tcril @jacobo-dominguez-wgu @mphilbrick211